This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Add test for flex-grow being less than one #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Automatic validation checks of commit 0c227d9 passed. |
Collaborator
Automatic validation checks of commit 0c227d9 passed. |
Collaborator
Automatic validation checks of commit 0c227d9 passed. |
|
Maybe add a test for flex-shrink for this circumstance as well? |
Member
Author
|
@cbiesinger Yeah, I have some vague plan to improve flexbox coverage, but getting browsers running tests is higher priority for now. |
0c227d9 to
de09714
Compare
Collaborator
Automatic validation checks of commit de09714 passed. |
Collaborator
Automatic validation checks of commit d3d47be passed. |
gsnedders
commented
Nov 1, 2016
| } | ||
| #test2 > div { | ||
| flex-shrink: 0.25; | ||
| width: 75px; |
Member
Author
There was a problem hiding this comment.
I've done the maths for this three times and got three different results. (I've gone wrong in different places each time!) From the one time I got what every browser does, can someone else confirm that this doesn't run into (undefined) rounding issues?
d3d47be to
f0277ff
Compare
Collaborator
Automatic validation checks of commit f0277ff passed. |
This was accidentally tested prior to w3c#1104.
f0277ff to
161d427
Compare
Collaborator
Automatic validation checks of commit 161d427 passed. |
fantasai
approved these changes
Mar 25, 2017
Collaborator
fantasai
left a comment
There was a problem hiding this comment.
I think we also need a test similar to #test2 that uses two different sizes for the two items, but what's here is correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally tested prior to #1104 (but incorrectly).
This change is